Quoting dikshita@xxxxxxxxxxxxxx (2020-12-06 22:13:30)
> From: Dikshita Agarwal <dikshita@xxxxxxxxxxxxxx>
>
> Add support to dump video FW region during FW crash
> using devcoredump helpers.
>
> Signed-off-by: Dikshita Agarwal <dikshita@xxxxxxxxxxxxxx>
> ---
One nit below.
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
Usually this contains a "Changes from v1" section. What changed?
> drivers/media/platform/qcom/venus/core.c | 31 ++++++++++++++++++++++++++++
> drivers/media/platform/qcom/venus/core.h | 2 ++
> drivers/media/platform/qcom/venus/firmware.c | 3 +++
> 3 files changed, 36 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 5102403..f23923d 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -22,6 +24,33 @@
> #include "firmware.h"
> #include "pm_helpers.h"
>
> +static void venus_coredump(struct venus_core *core)
> +{
> + struct device *dev;
> + phys_addr_t mem_phys;
> + size_t mem_size;
> + void *mem_va;
> + void *data;
> +
> + dev = core->dev;
> + mem_phys = core->fw.mem_phys;
> + mem_size = core->fw.mem_size;
> +
> + mem_va = memremap(mem_phys, mem_size, MEMREMAP_WC);
> + if (!mem_va)
> + return;
> +
> + data = vmalloc(mem_size);
> + if (!data) {
> + memunmap(mem_va);
> + return;
> + }
> +
> + memcpy(data, mem_va, mem_size);
> + dev_coredumpv(dev, data, mem_size, GFP_KERNEL);
> + memunmap(mem_va);
Technically we could unmap right after memcpy() so that the mapping only
exists for the memcpy() and then mem_va isn't "alive" for the
dev_coredumpv() call.
> +}
> +
> static void venus_event_notify(struct venus_core *core, u32 event)
