Hi Dan, On Mon, Dec 07, 2020 at 04:00:29PM +0300, Dan Carpenter wrote: > The "ret" variable isn't set on the no-op path where we are setting to > on/off and it's in the on or off state already. > > Fixes: 91807efbe8ec ("media: i2c: add OV02A10 image sensor driver") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks for the patch. This issue has been fixed by another patch here: <URL:https://patchwork.linuxtv.org/project/linux-media/patch/20201204082037.1658297-1-arnd@xxxxxxxxxx/> -- Kind regards, Sakari Ailus