Hi Hans, Thanks for the patch. On Mon, Dec 07, 2020 at 12:18:55PM +0100, Hans Verkuil wrote: > This driver does not support composition, only cropping. > Composition means that the sensor can output e.g. 1920x1080, > but can compose a cropped 1280x720 image in the middle of the > 1920x1080 canvas, filling in the unused area with a background > color. That's how this would work on V4L2 video nodes... > > That's not supported at all. So drop the bogus composition support. But this is a sub-device driver. On sub-devices the COMPOSE target is used for configuring scaling, binning and sub-sampling. I don't know about the capabilities of this particular driver but the code (__imx274_change_compose function in particular) looks very much such that it does support binning. -- Kind regards, Sakari Ailus
