Re: [PATCH] media: smiapp: avoid printing an uninitialized variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd,

Thanks for the patch.

On Thu, Dec 03, 2020 at 11:28:16PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> There is no intialization for the 'reg' variable, so printing
> it produces undefined behavior as well as a compile-time warning:
> 
> drivers/media/i2c/ccs/ccs-core.c:314:49: error: variable 'reg' is uninitialized when used here [-Werror,-Wuninitialized]
>                         "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
> 
> Remove the variable and stop printing it.
> 
> Fixes: b24cc2a18c50 ("media: smiapp: Rename as "ccs"")

The patch introducing this was 

fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")

so I'll use it instead. Also s/smiapp/ccs/ in the subject.

Interesting that GCC 8.3 didn't complain.

-- 
Kind regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux