On Thu, Dec 03, 2020 at 02:25:15PM +0100, Greg KH wrote: > On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote: > > Remove MODULE_VERSION(), as it doesn't seem to serve any practical > > purpose. For in-tree drivers, the kernel version matters. > > > > The drivers have received lots of changes, without the module version > > (or the underlying DRV_VERSION macro) ever changed, since the code > > landed in the kernel tree. So, it doesn't seem to have any practical > > meaning anymore. > > > > Signed-off-by: Enrico Weigelt <info@xxxxxxxxx> > > --- > > drivers/accessibility/speakup/main.c | 1 - > > <snip> > > Yous subject line is odd, these are not "staging" drivers anymore, so > why do you say they are there? Also putting "drivers:" in the subject always seems superfluous. regards, dan carpenter