Hi Klaus, On Sun, Apr 11, 2010 at 1:12 PM, Klaus Schmidinger <Klaus.Schmidinger@xxxxxxx> wrote: > The enum fe_caps provides flags that allow an application to detect > whether a device is capable of handling various modulation types etc. > A flag for detecting PSK_8, however, is missing. > This patch adds the flag FE_CAN_PSK_8 to frontend.h and implements > it for the gp8psk-fe.c and cx24116.c driver (apparently the only ones > with PSK_8). Only the gp8psk-fe.c has been explicitly tested, though. The FE_CAN_PSK_8 is a misnomer. In fact what you are looking for is FE_CAN_TURBO_FEC FE_CAN_8PSK will be matched by any DVB-S2 capable frontend, so that name is very likely to cause a very large confusion. Another thing I am not entirely sure though ... The cx24116 requires a separate firmware and maybe some necessary code changes (?) for Turbo FEC to be supported, so I wonder whether applying the flag to the cx24116 driver would be any relevant.... With regards to the Genpix driver, i guess the flag would be necessary. > Signed-off-by: Klaus Schmidinger <Klaus.Schmidinger@xxxxxxx> > Tested-by: Derek Kelly <user.vdr@xxxxxxxxx> Other than for the naming of the Flag (which i suggest strongly to update the patch) and the application to the cx24116 driver, it looks appropriate; Acked-by: Manu Abraham <manu@xxxxxxxxxxx> > > > --- linux/include/linux/dvb/frontend.h.001 2010-04-05 16:13:08.000000000 +0200 > +++ linux/include/linux/dvb/frontend.h 2010-04-10 12:08:47.000000000 +0200 > @@ -62,6 +62,7 @@ > FE_CAN_8VSB = 0x200000, > FE_CAN_16VSB = 0x400000, > FE_HAS_EXTENDED_CAPS = 0x800000, /* We need more bitspace for newer APIs, indicate this. */ > + FE_CAN_PSK_8 = 0x8000000, /* frontend supports "8psk modulation" */ > FE_CAN_2G_MODULATION = 0x10000000, /* frontend supports "2nd generation modulation" (DVB-S2) */ > FE_NEEDS_BENDING = 0x20000000, /* not supported anymore, don't use (frontend requires frequency bending) */ > FE_CAN_RECOVER = 0x40000000, /* frontend can recover from a cable unplug automatically */ > --- linux/drivers/media/dvb/dvb-usb/gp8psk-fe.c.001 2010-04-05 16:13:08.000000000 +0200 > +++ linux/drivers/media/dvb/dvb-usb/gp8psk-fe.c 2010-04-10 12:18:37.000000000 +0200 > @@ -349,7 +349,7 @@ > * FE_CAN_QAM_16 is for compatibility > * (Myth incorrectly detects Turbo-QPSK as plain QAM-16) > */ > - FE_CAN_QPSK | FE_CAN_QAM_16 > + FE_CAN_QPSK | FE_CAN_QAM_16 | FE_CAN_PSK_8 > }, > > .release = gp8psk_fe_release, > --- linux/drivers/media/dvb/frontends/cx24116.c.001 2010-04-05 16:13:08.000000000 +0200 > +++ linux/drivers/media/dvb/frontends/cx24116.c 2010-04-10 13:40:32.000000000 +0200 > @@ -1496,7 +1496,7 @@ > FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 | > FE_CAN_FEC_7_8 | FE_CAN_FEC_AUTO | > FE_CAN_2G_MODULATION | > - FE_CAN_QPSK | FE_CAN_RECOVER > + FE_CAN_QPSK | FE_CAN_RECOVER | FE_CAN_PSK_8 > }, > > .release = cx24116_release, > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
