Hi Hans, Thanks your correction and direction. I will submit a complete formal patch for review in a few days. BRs Xiaolin -----Original Message----- From: Hans Verkuil [mailto:hverkuil@xxxxxxxxx] Sent: Tuesday, April 13, 2010 9:42 PM To: Zhang, Xiaolin Cc: linux-media@xxxxxxxxxxxxxxx; Zhu, Daniel; Bian, Jonathan Subject: Re: [RFC] support more color effects by extending the V4L2_CID_COLORFX user control ID > Hi linux-media, > > Current V4l2 support a limited image effects (black white and sepia) and > this is a RFC to support more color effects by extending the > V4L2_CID_COLORFX user control ID, these effects are not platform specific > and are available in mainstream digital camera devices, and will be > supported by the ISP on Intel Atom platforms. > > The image effects are listed as in below, we are proposing to extend > V4L2_CID_COLORFX to support them: > > V4L2_COLORFX_NEGATIVE - negative image effect. > V4L2_COLORFX_EMBOSS - emboss image effect > V4L2_COLORFX_SKETECH - sketch image effect > V4L2_COLORFX_SKY_BLUE - sky blue image effect > V4L2_COLORFX_GRASS_GREEN - grass green image effect > V4L2_COLORFX_SKIN_WHITEN - skin whiten image effect > V4L2_COLORFX_VIVID - vivid image effect > > The v4l2_colorfx also needs to contain more enum items (as in below) to > support them, welcome any comment and suggest. > > enum v4l2_colorfx { > V4L2_COLORFX_DEFAULT = 0, > V4L2_COLORFX_BW = 1, > V4L2_COLORFX_SEPIA = 2, > V4L2_COLORFX_NEGATIVE = 3, > V4L2_COLORFX_EMBOSS =4, > V4L2_COLORFX_SKETECH =5, Typo: SKETECH -> SKETCH > V4L2_COLORFX_SKY_BLUE =6, > V4L2_COLORFX_GRASS_GREEN =7, > V4L2_COLORFX_SKIN_WHITEN = 8, > V4L2_COLORFX_VIVID = 9, > }; Looks fine to me! Remember to also change v4l2_ctrl_get_menu() in v4l2-common.c. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
