Hi Daniel, Thank you for the patch. The subject line is very long. We try to keep it within a 72 characters limit in the kernel. That can be a challenge sometimes, and expections can be accepted, but this one is reaaaally long. (The same comment holds for other patches in the series) On Mon, Nov 30, 2020 at 01:31:17PM +0000, Daniel Scally wrote: > To maintain consistency with software_node_unregister_nodes(), reverse > the order in which the software_node_unregister_node_group() function > unregisters nodes. > > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: Daniel Scally <djrscally@xxxxxxxxx> I"d squash this with the previous patch to avoid introducing an inconsistency. Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Changes since v3: > > Patch introduced > > drivers/base/swnode.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index d39e1c76d98d..9bd0bb77ad5b 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -782,7 +782,10 @@ void software_node_unregister_node_group(const struct software_node **node_group > if (!node_group) > return; > > - for (i = 0; node_group[i]; i++) > + while (node_group[i]->name) > + i++; > + > + while (i--) > software_node_unregister(node_group[i]); > } > EXPORT_SYMBOL_GPL(software_node_unregister_node_group); -- Regards, Laurent Pinchart
