Hi Peilin,
On 11/26/20 9:21 AM, Peilin Ye wrote:
> Fix 4 typos under drivers/media/platform/rockchip/rkisp1/ found by
> checkpatch, including the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macro
> definitions.
>
> Signed-off-by: Peilin Ye <yepeilin.cs@xxxxxxxxx>
Thanks
Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>
> ---
> Hi Helen, Dafna,
>
> I noticed that the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macros are not
> being used yet, but according to page 12 of this developer guide [1] I
> think they are for *enabling* the ping-pong ("double buffers") mode?
Looks like. The documentation I have doesn't explain much about this
mode, it just mention that bit is used to enable it, and that
MI_{MP,SP}_{CR,CB}_BASE_AD_INIT2 are used to configure base address 2.
Regards,
Helen
>
> Based on linux-next 9d3e48f20e11 ("Add linux-next specific files for
> 20201125").
>
> Thanks,
> Peilin Ye
>
> [1] https://dl.vamrs.com/products/rock960/docs/sw/Rockchip%C2%A0Linux%20Camera%C2%A0Developer%20Guide%20V1.1.pdf#page=12
>
> drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 4 ++--
> drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> index b81235afd053..94b65680c4c1 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> @@ -46,7 +46,7 @@ enum rkisp1_plane {
> /*
> * @fourcc: pixel format
> * @fmt_type: helper filed for pixel format
> - * @uv_swap: if cb cr swaped, for yuv
> + * @uv_swap: if cb cr swapped, for yuv
> * @write_format: defines how YCbCr self picture data is written to memory
> * @output_format: defines sp output format
> * @mbus: the mbus code on the src resizer pad that matches the pixel format
> @@ -870,7 +870,7 @@ static void rkisp1_cap_stream_disable(struct rkisp1_capture *cap)
> {
> int ret;
>
> - /* Stream should stop in interrupt. If it dosn't, stop it by force. */
> + /* Stream should stop in interrupt. If it doesn't, stop it by force. */
> cap->is_stopping = true;
> ret = wait_event_timeout(cap->done,
> !cap->is_streaming,
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
> index 049f6c3a11df..8a8d960a679c 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h
> @@ -106,8 +106,8 @@
> #define RKISP1_CIF_MI_SP_Y_FULL_YUV2RGB BIT(8)
> #define RKISP1_CIF_MI_SP_CBCR_FULL_YUV2RGB BIT(9)
> #define RKISP1_CIF_MI_SP_422NONCOSITEED BIT(10)
> -#define RKISP1_CIF_MI_MP_PINGPONG_ENABEL BIT(11)
> -#define RKISP1_CIF_MI_SP_PINGPONG_ENABEL BIT(12)
> +#define RKISP1_CIF_MI_MP_PINGPONG_ENABLE BIT(11)
> +#define RKISP1_CIF_MI_SP_PINGPONG_ENABLE BIT(12)
> #define RKISP1_CIF_MI_MP_AUTOUPDATE_ENABLE BIT(13)
> #define RKISP1_CIF_MI_SP_AUTOUPDATE_ENABLE BIT(14)
> #define RKISP1_CIF_MI_LAST_PIXEL_SIG_ENABLE BIT(15)
>
