Hey Andrey, Thanks for finding this issue, reverting and coming up with a better solution seems like a good idea. With the above nit fix, feel free to add my r-b. Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx> On Thu, 26 Nov 2020 at 11:20, Marc Gonzalez <marc.w.gonzalez@xxxxxxx> wrote: > > On 25/11/2020 13:37, Andrey Konovalov wrote: > > > This reverts commit c90f1178dcac30dee5ddd29ec0513e7589aa866e. > > > > The assumption of "Each entry in formats[] table has unique mbus_code" > > is valid for the RDI entities, but not for the PIX ones. > > > > Reverting this patch and creating a new one which handles the PIX entities > > correctly results in smaller and more straitforward patch than doing the > > changes on top of the current version. > > > s/straitforward/straightforward ;-)