Hi Michael, On Wed, Nov 25, 2020 at 7:36 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > > - out_be32(&vr->dma_inc, reg_val.dma_inc); > > - out_be32(&vr->picture_count, reg_val.picture_count); > > - out_be32(&vr->field_base_addr, reg_val.field_base_addr); > > + iowrite32be(reg_val.dma_inc, &vr->dma_inc); > > + iowrite32be(reg_val.picture_count, &vr->picture_count); > > + iowrite32be(reg_val.field_base_addr, &vr->picture_count); > > That last conversion is wrong. Good catch, thanks! I have sent a v2.
