On 11/24/20 09:41, Marek Szyprowski wrote: > Properly set device pointers in videobuf2 queues, so the videobuf2 > debugging messages will be prefixed with the respective device name. > > Signed-off-by: Marek Szyprowski<m.szyprowski@xxxxxxxxxxx> > --- > This patch was previously sent as part of "[PATCH v2 0/4] Exynos4 media > drivers: adapt for the planned ARM IOMMU-DMA changes" patchset: > https://lore.kernel.org/linux-samsung-soc/20200918144833.14618-1-m.szyprowski@xxxxxxxxxxx/ > The IOMMU related changes are still under review, but this change is > unrelated and it makes sense to aplly it separately. > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c > index eba2b9f040df..4e50c342b322 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c > @@ -844,6 +844,7 @@ static int s5p_mfc_open(struct file *file) > q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; > q->drv_priv = &ctx->fh; > q->lock = &dev->mfc_mutex; > + q->dev = &dev->plat_dev->dev; I can't see where q->dev is used for debug logs, shouldn't we use v4l2_queue_init_name() instead? -- Regards, Sylwester
