Re: [PATCH 2/2 v5] leds: rt8515: Add Richtek RT8515 LED driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 22, 2020 at 12:50 PM Sakari Ailus <sakari.ailus@xxxxxx> wrote:

> > +static int rt8515_led_flash_strobe_set(struct led_classdev_flash *fled,
> > +                                    bool state)
> > +{
> > +     struct rt8515 *rt = to_rt8515(fled);
> > +     struct led_flash_setting *timeout = &fled->timeout;
> > +     int brightness = 4; /* max 16 */
>
> Just a question on the unit --- did the other spec shed any light on what
> the relation between this setting and the current might be?

They just say:
"There are a total of 16 steps of current
level which can be set by users."

They do not say whether this is linear or not. So I have
assumed linear. The above is just a bug, it should should be
the configured max or max available of course. I'll fix!

Yours,
Linus Walleij



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux