Re: [PATCH] V4L/DVB: saa7146: IRQF_DISABLED causes only trouble

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-04-08 at 12:05 +0200, Bjørn Mork wrote:
> Ehh...., this is very embarrassing, but please disregard all my
> statements about a hanging system related to IRQF_DISABLED.
> 
> It turns out that I've had a faulty SATA hard drive which probably have
> caused all these problems.  I do not understand the inner workings of
> the SATA hardware and software, but it appears that this drive has been
> able to block interrupts for a considerable time without SMART detecting
> any error at all.  I wrongly suspected saa7146 to be the cause because
> these problems appeared after adding the saa7146 hardware.  But that was
> probably just a coincidence (or maybe not really, only unrelated: I
> suspect that the problem was triggered by the powercycle when adding
> this card)
> 
> The drive has now been replaced, and I will start verifying that use of
> saa7146 with IRQF_DISABLED does not in fact pose any real problems at
> all.

Don't bother.

It's probably a good thing you found your root cause.  Your patch was
going to be invalidated in the near future: 

	http://lwn.net/Articles/380931/

It appears that IRQF_DISABLED behavior is to be the default behavior for
all drivers and the flag is to have no effect.



> I still find the discussion about it's usefulness interesting though...

Good. :)


Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux