On Thu, Apr 8, 2010 at 7:50 AM, Huang Weiyi <weiyi.huang@xxxxxxxxx> wrote: > Remove unused #include <linux/version.h>('s) in > drivers/media/dvb/ngene/ngene-core.c > > Signed-off-by: Huang Weiyi <weiyi.huang@xxxxxxxxx> > --- > drivers/media/dvb/ngene/ngene-core.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c > index 645e8b8..6dc567b 100644 > --- a/drivers/media/dvb/ngene/ngene-core.c > +++ b/drivers/media/dvb/ngene/ngene-core.c > @@ -37,7 +37,6 @@ > #include <linux/pci_ids.h> > #include <linux/smp_lock.h> > #include <linux/timer.h> > -#include <linux/version.h> > #include <linux/byteorder/generic.h> > #include <linux/firmware.h> > #include <linux/vmalloc.h> Hello Huang, I just wanted to let you know that KernelLabs has a rather large project ongoing to clean up the ngene driver. So while I have no objection to this patch in principle, please be advised that there is not much value in doing additional cleanup to that driver as it is likely to be redundant (and will just increase our work in merging the changes upstream). Cheers, Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html