On 11/12/20 7:25 AM, Dafna Hirschfeld wrote: > > > Am 06.11.20 um 13:19 schrieb Helen Koike: >> Hello, >> >> Changes in v3: >> - Moved Kconfig entry from M2M to Platform devices >> - Rename description and comment to Parameters and Statistics. >> - Patches squashed: >> dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging >> media: MAINTAINERS: rkisp1: add path to dt-bindings >> media: rockchip: rkisp1: destage Rockchip ISP1 driver >> media: MAINTAINERS: Update rkisp1 files with new location >> >> Changes in v2: >> - New patch updating MAINTAINERS file >> - No changes in other patches >> >>> media-ctl -p >> http://ix.io/2Cso >> >>> media-ctl --print-dot >> http://ix.io/2Csp >> >>> v4l2-compliance -m0 >> http://ix.io/2Csk > > Hello Dave, > > I see the above link that the imx219 does not pass the compliance: > > fail: v4l2-test-controls.cpp(830): failed to find event for control 'Exposure' > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL > > I see this patch on downstream > "media: i2c: imx219: Declare that the driver can create events" > > That adds the flag V4L2_SUBDEV_FL_HAS_EVENTS, I suspect that is the patch > that fixes the compliance issue. > > I can verify that and send the patch to the mailing list, > is it ok with you? Sure, thanks! Helen > > Thanks, > Dafna > > > >> >>> v4l2-compliance -v -d /dev/video0 -s10 >> http://ix.io/2Csq >> >>> v4l2-compliance -v -d /dev/video1 -s10 >> http://ix.io/2Css >> >> Helen Koike (1): >> media: rockchip: rkisp1: destage Rockchip ISP1 driver >> >> Shunqian Zheng (1): >> media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format >> >> .../bindings/media/rockchip-isp1.yaml | 0 >> .../media/v4l/pixfmt-meta-rkisp1.rst | 2 +- >> MAINTAINERS | 5 ++++- >> drivers/media/platform/Kconfig | 18 ++++++++++++++++++ >> drivers/media/platform/Makefile | 1 + >> .../platform/rockchip}/rkisp1/Makefile | 0 >> .../rockchip}/rkisp1/rkisp1-capture.c | 0 >> .../platform/rockchip}/rkisp1/rkisp1-common.c | 0 >> .../platform/rockchip}/rkisp1/rkisp1-common.h | 2 +- >> .../platform/rockchip}/rkisp1/rkisp1-dev.c | 0 >> .../platform/rockchip}/rkisp1/rkisp1-isp.c | 0 >> .../platform/rockchip}/rkisp1/rkisp1-params.c | 0 >> .../platform/rockchip}/rkisp1/rkisp1-regs.h | 0 >> .../rockchip}/rkisp1/rkisp1-resizer.c | 0 >> .../platform/rockchip}/rkisp1/rkisp1-stats.c | 0 >> drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ >> drivers/staging/media/Kconfig | 2 -- >> drivers/staging/media/Makefile | 1 - >> drivers/staging/media/rkisp1/Kconfig | 19 ------------------- >> drivers/staging/media/rkisp1/TODO | 6 ------ >> .../uapi/linux}/rkisp1-config.h | 4 ---- >> include/uapi/linux/videodev2.h | 4 ++++ >> 22 files changed, 31 insertions(+), 35 deletions(-) >> rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/Makefile (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-capture.c (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-common.c (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-common.h (99%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-dev.c (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-isp.c (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-params.c (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-regs.h (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-resizer.c (100%) >> rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-stats.c (100%) >> delete mode 100644 drivers/staging/media/rkisp1/Kconfig >> delete mode 100644 drivers/staging/media/rkisp1/TODO >> rename {drivers/staging/media/rkisp1/uapi => include/uapi/linux}/rkisp1-config.h (99%) >>
