On Tue, Nov 10, 2020 at 10:17:27AM +0000, Sean Young wrote:
On Mon, Nov 09, 2020 at 04:23:09PM +0100, Michael Klein wrote:
The default recorder timeout of 125ms is too high for some BPF protocol
decoders when a remote sends repeat codes at high rates. This makes the
timeout configurable via the devicetree.
To be honest, 125ms is too much by any measurement. The longest space
in any protocol I'm aware of is 40ms in the sharp ir protocol. I think
changing IR_DEFAUL_TIMEOUT to something like 50ms would make sense.
Seconded. I'm happy to prepare a patch if changing the default value is
acceptable.
Also, when an BPF protocol is loaded, user-space can set the timeout
with the LIRC_SET_REC_TIMEOUT ioctl which can depend on the protocol
(set to longest space + 10ms error margin).
Right, although this is a bit cumbersome with current user-space tools.
The BPF is loaded with ir-keytable, while the recorder timeout needs to
be set with it-ctl. In the Debian world, those tools are even in
different packages.
This would mean that the
bare minimum timeout can be set, which means decoding is as responsive
as can be.
I'm not sure that device tree is really the place for this.
Not arguing about this, but IMHO no less than for rc-map-name. So this
seems to be at least consistent.
Thanks,
Michael
