Hi Bingbu,
On Mon, Nov 09, 2020 at 03:39:40PM +0800, Bingbu Cao wrote:
> OTP data access of ov2740 in probe need power up, it may cause
> the camera flash LED blink during probe if the LED use same power
> rail with camera, this patch move the OTP data access out of
> probe, it will only occur on demand from user by nvmem sysfs.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@xxxxxxxxx>
> Signed-off-by: Qingwu Zhang <qingwu.zhang@xxxxxxxxx>
> ---
> drivers/media/i2c/ov2740.c | 87 +++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 66 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
> index 64ecb6917dd3..4bb4fe4bcab6 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -71,9 +71,11 @@
> #define OV2740_REG_OTP_CUSTOMER 0x7010
>
> struct nvm_data {
> - char *nvm_buffer;
> + struct i2c_client *client;
> struct nvmem_device *nvmem;
> struct regmap *regmap;
> + char *nvm_buffer;
> + bool ready;
Thanks for the update, this indeed makes the set much easier to review.
Would it be possible to just rely on the nvm_buffer, and remove ready
field? Essentially, having NULL nvm_buffer would tell the memory isn't
allocated nor the NVM data is loaded. What do you think?
This would also mean moving the memory allocation where NVM data is read.
--
Kind regards,
Sakari Ailus
