Hi Mauro, Thanks for the review comments. On Thu, Nov 05, 2020 at 01:42:43PM +0100, Mauro Carvalho Chehab wrote: > Em Wed, 7 Oct 2020 11:45:56 +0300 > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu: > > > Add controls for supporting lens shading correction. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > For patches 098 to 105, we should at least have those new controls > documented at the uAPI documents. Agreed. > > I'm not convinced yet that we shouldn't instead place them inside > V4L2_CTRL_CLASS_CAMERA. > > As those are part of a MIPI standard, I won't doubt that sooner or > later, other drivers may need them. They are part of a MIPI standard, but that standard defines a control interface for camera sensors which this driver uses. I don't see a need to implement other drivers for devices this driver already supports. Note that while MIPI standards are originally centered around cross-chip busses, the functionality that is being controlled here is entirely local to the device. Quite a few of the controls are still somehow specific to the device. That said, the same analogue gain model is very likely present on a range of devices even though they are not CCS (or SMIA) compatible, for historical reasons. Perhaps these could be actually made a single array control in the camera control class, with indices defined for the different factors. -- Kind regards, Sakari Ailus
