Hi Mauro,
Thanks for the review.
On Thu, Nov 05, 2020 at 11:50:32AM +0100, Mauro Carvalho Chehab wrote:
...
> > +struct __ccs_data_block_end {
> > + uint8_t crc[4];
> > +} __attribute__((packed));
> > +
> > +#endif /* __CCS_DATA_DEFS_H__ */
>
> Nitpick: why all the above struct/enums start with "__"?
We have two sets of data structure: those that are related to the binary
file format (these, so they're packed) as well as the in-kernel
representation. So I've used the underscores to designate these are the
binary format ones. They're only used in ccs-data.c.
--
Kind regards,
Sakari Ailus
