On Thu, 2020-11-05 at 00:01 +0100, Ricardo Ribalda wrote: > Hi Joe > > On Thu, Nov 5, 2020 at 12:00 AM Joe Perches <joe@xxxxxxxxxxx> wrote: > > > > On Wed, 2020-11-04 at 23:31 +0100, Ricardo Ribalda wrote: > > > > > I have updated my tree with the dev_ variants > > > > > > https://github.com/ribalda/linux/commit/b8785fd8efb4f2e5bbf5d0f2df3e0d69a5439015 > > > > I looked at this link and was confused so you made me look. > > I think you meant: > > > > https://github.com/ribalda/linux/commit/83cb6eb3a9f7bd1954acbfb4fb3d56ddf54bce73 > > Yes, thanks :) Sorry about that > > This is why I should be away from a keyboard after 23:00 :) Sleep is good. There are lots of sleep deprived people here in the US today though. It looks as if all the pr_cont uses in the code are odd and repetitive. Perhaps it'd be sensible to add something like: #define uvc_trace_cont(flag, fmt, ...) \ do { \ if (uvc_trace_param & (flag)) \ pr_cont(fmt, ##__VA_ARGS__); \ } while (0) and change all the uses like: - if (uvc_trace_param & UVC_TRACE_PROBE) - printk(KERN_CONT " <- SU %d", entity->id); + uvc_trace_cont(UVC_TRACE_PROBE, " <- SU %d", entity->id);
