Hi Laurent,
This was still on my TODO list to review. Of the other patch only my comment
for 100/108 needs to be addressed in a v3.
I have just one comment for this patch:
On 06/07/2020 20:37, Laurent Pinchart wrote:
> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
> index 293cbac905b3..2ce2b6404c92 100644
> --- a/drivers/media/platform/ti-vpe/cal.c
> +++ b/drivers/media/platform/ti-vpe/cal.c
> @@ -43,6 +43,10 @@ unsigned int cal_debug;
> module_param_named(debug, cal_debug, uint, 0644);
> MODULE_PARM_DESC(debug, "activates debug info");
>
> +bool cal_mc_api;
> +module_param_named(mc_api, cal_mc_api, bool, 0444);
> +MODULE_PARM_DESC(mc_api, "activates the MC API");
I think it would be very useful if a Kconfig option is added that selects
the default of cal_mc_api. If you know that you want the MC API, then you
can select the option and that will be the default.
It is probably best if you rebase this series, fix 100/108 and (hopefully)
this patch and post it as a v3. I'll take it.
Regards,
Hans
> +
> /* ------------------------------------------------------------------
> * Format Handling
> * ------------------------------------------------------------------
> @@ -660,13 +664,17 @@ static int cal_async_notifier_complete(struct v4l2_async_notifier *notifier)
> {
> struct cal_dev *cal = container_of(notifier, struct cal_dev, notifier);
> unsigned int i;
> + int ret = 0;
>
> for (i = 0; i < ARRAY_SIZE(cal->ctx); ++i) {
> if (cal->ctx[i])
> cal_ctx_v4l2_register(cal->ctx[i]);
> }
>
> - return 0;
> + if (cal_mc_api)
> + ret = v4l2_device_register_subdev_nodes(&cal->v4l2_dev);
> +
> + return ret;
> }
>
> static const struct v4l2_async_notifier_operations cal_async_notifier_ops = {
> diff --git a/drivers/media/platform/ti-vpe/cal.h b/drivers/media/platform/ti-vpe/cal.h
> index 2d935691bf75..f5609216b7c6 100644
> --- a/drivers/media/platform/ti-vpe/cal.h
> +++ b/drivers/media/platform/ti-vpe/cal.h
> @@ -160,6 +160,7 @@ struct cal_camerarx {
> struct device_node *sensor_ep_node;
> struct device_node *sensor_node;
> struct v4l2_subdev *sensor;
> + struct media_pipeline pipe;
>
> struct v4l2_subdev subdev;
> struct media_pad pads[2];
> @@ -224,6 +225,7 @@ struct cal_ctx {
>
> extern unsigned int cal_debug;
> extern int cal_video_nr;
> +extern bool cal_mc_api;
>
> #define cal_dbg(level, cal, fmt, arg...) \
> do { \
>
