On 30/10/2020 12:34, Dafna Hirschfeld wrote: > > > Am 30.10.20 um 09:58 schrieb Hans Verkuil: >> On 20/10/2020 17:45, Dafna Hirschfeld wrote: >>> MEDIA_BUS_FMT_METADATA_FIXED should be used when >>> the same driver handles both sides of the link and >>> the bus format is a fixed metadata format that is >>> not configurable from userspace. >>> The width and height will be set to 0 for this format. >>> >>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> >>> Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx> >>> --- >>> changes since v1: >>> 1. replace "This format may have 0 height and width." >>> with "Width and height will be set to 0 for this format." >>> and add it also to the commit log >>> 2. s/meida:/media:/ in the patch subject line >>> >>> include/uapi/linux/media-bus-format.h | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h >>> index 84fa53ffb13f..2ce3d891d344 100644 >>> --- a/include/uapi/linux/media-bus-format.h >>> +++ b/include/uapi/linux/media-bus-format.h >>> @@ -156,4 +156,12 @@ >>> /* HSV - next is 0x6002 */ >>> #define MEDIA_BUS_FMT_AHSV8888_1X32 0x6001 >>> >>> +/* >>> + * This format should be used when the same driver handles >>> + * both sides of the link and the bus format is a fixed >>> + * metadata format that is not configurable from userspace. >>> + * Width and height will be set to 0 for this format. >>> + */ >>> +#define MEDIA_BUS_FMT_METADATA_FIXED 0x7001 >>> + >>> #endif /* __LINUX_MEDIA_BUS_FORMAT_H */ >>> >> >> Documentation/userspace-api/media/v4l/subdev-formats.rst also needs to >> be updated. > > hi, > I wonder what should be the documentation, since this mbus code Basically the same as you wrote in the comment above. > is for very specific use case. You think that the 0x7* mbus codes > should be 'metadata mbus codes'? Yes. Regards, Hans
