On 30/10/2020 06:51, Helen Koike wrote: > Hello, > > I think it is time to move this driver out of staging. > > Thanks all who contributed, specially to Dafna, who put a lot of > effort addressing all the items in the TODO list, fixing bugs, > cleaning the code, addressing past comments and testing. > > Please, review the driver, see if there is any other thing that should > be addressed before this change. I didn't see a MAINTAINERS patch! Regards, Hans > >> media-ctl -p > http://ix.io/2Cso > >> media-ctl --print-dot > http://ix.io/2Csp > >> v4l2-compliance -m0 > http://ix.io/2Csk > >> v4l2-compliance -v -d /dev/video0 -s10 > http://ix.io/2Csq > >> v4l2-compliance -v -d /dev/video1 -s10 > http://ix.io/2Css > > This patch depends on the following series: > > * media: staging: rkisp1: uapi: add "WITH Linux-syscall-note" > https://patchwork.linuxtv.org/project/linux-media/patch/20201020132514.26651-1-dafna.hirschfeld@xxxxxxxxxxxxx/ > > * [0/2] media: staging: rkisp1: Fix formats for metadata pads > https://patchwork.linuxtv.org/project/linux-media/cover/20200325212704.29862-1-dafna.hirschfeld@xxxxxxxxxxxxx/ > > * [v2,1/2] media: uapi: add MEDIA_BUS_FMT_METADATA_FIXED media bus format. > [v2,2/2] media: staging: rkisp1: isp: set metadata pads to MEDIA_BUS_FMT_METADATA_FIXED > https://patchwork.linuxtv.org/project/linux-media/patch/20201020154522.654-1-dafna.hirschfeld@xxxxxxxxxxxxx/ > > * [0/6] media: staging: rkisp1: improvements > https://patchwork.linuxtv.org/project/linux-media/cover/20201002184222.7094-1-dafna.hirschfeld@xxxxxxxxxxxxx/ > > * [0/4] media: staging: rkisp1: send cleanups and checkpatch fixes > https://patchwork.linuxtv.org/project/linux-media/cover/20201019205956.6980-1-dafna.hirschfeld@xxxxxxxxxxxxx/ > > * media: staging: rkisp1: capture: set default quantization on 'set_fmt' > https://patchwork.linuxtv.org/project/linux-media/patch/20201026162848.18310-1-dafna.hirschfeld@xxxxxxxxxxxxx/ > > * media: staging: rkisp1: remove TODO item to document quantization handling > https://patchwork.linuxtv.org/project/linux-media/patch/20200928152809.27490-1-dafna.hirschfeld@xxxxxxxxxxxxx/ > > * [v2] media: staging: rkisp1: cap: refactor enable/disable stream to allow multistreaming > https://patchwork.linuxtv.org/project/linux-media/patch/20201019160434.877568-1-helen.koike@xxxxxxxxxxxxx/ > > * [v6,0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 > https://patchwork.linuxtv.org/project/linux-media/patch/20201020193850.1460644-2-helen.koike@xxxxxxxxxxxxx/ > > You can also see all of them applied in this branch: > > https://gitlab.collabora.com/koike/linux/-/tree/rockchip/isp/destage > > Thanks > Helen > > Helen Koike (1): > media: rockchip: rkisp1: destage Rockchip ISP1 driver > > Shunqian Zheng (1): > media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format > > .../media/v4l/pixfmt-meta-rkisp1.rst | 2 +- > drivers/media/platform/Kconfig | 18 ++++++++++++++++++ > drivers/media/platform/Makefile | 1 + > .../platform/rockchip}/rkisp1/Makefile | 0 > .../rockchip}/rkisp1/rkisp1-capture.c | 0 > .../platform/rockchip}/rkisp1/rkisp1-common.c | 0 > .../platform/rockchip}/rkisp1/rkisp1-common.h | 2 +- > .../platform/rockchip}/rkisp1/rkisp1-dev.c | 0 > .../platform/rockchip}/rkisp1/rkisp1-isp.c | 0 > .../platform/rockchip}/rkisp1/rkisp1-params.c | 0 > .../platform/rockchip}/rkisp1/rkisp1-regs.h | 0 > .../rockchip}/rkisp1/rkisp1-resizer.c | 0 > .../platform/rockchip}/rkisp1/rkisp1-stats.c | 0 > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > drivers/staging/media/Kconfig | 2 -- > drivers/staging/media/Makefile | 1 - > drivers/staging/media/rkisp1/Kconfig | 19 ------------------- > drivers/staging/media/rkisp1/TODO | 6 ------ > .../uapi/linux}/rkisp1-config.h | 4 ---- > include/uapi/linux/videodev2.h | 4 ++++ > 20 files changed, 27 insertions(+), 34 deletions(-) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/Makefile (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-capture.c (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-common.c (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-common.h (99%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-dev.c (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-isp.c (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-params.c (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-regs.h (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-resizer.c (100%) > rename drivers/{staging/media => media/platform/rockchip}/rkisp1/rkisp1-stats.c (100%) > delete mode 100644 drivers/staging/media/rkisp1/Kconfig > delete mode 100644 drivers/staging/media/rkisp1/TODO > rename {drivers/staging/media/rkisp1/uapi => include/uapi/linux}/rkisp1-config.h (99%) >
