On Wed, Oct 28, 2020 at 04:11:05PM +0800, Bingbu Cao wrote: > Andy, thanks for your patch. > Reviewed-by: Bingbu Cao <bingbu.cao@xxxxxxxxx> Thanks! > On 10/28/20 2:14 AM, Andy Shevchenko wrote: > > - entry[1].second_entry.last_page_available_bytes = > > - (remaining & ~PAGE_MASK) ? > > - (remaining & ~PAGE_MASK) - 1 : PAGE_SIZE - 1; > > + remaining = offset_in_page(remaining); > > + entry[1].second_entry.last_page_available_bytes = (remaining ?: PAGE_SIZE) - 1; > > Not really about this change, is there some coding style update? This line obviously over 80 > chars, but the latest script did not report warning. There is a relaxation in the script, but now it's ambiguous with the documentation. I just realized I can rewrite this as: remaining = offset_in_page(remaining) ?: PAGE_SIZE; entry[1].second_entry.last_page_available_bytes = remaining - 1; Would it work for you? > > /* Fill FBPT */ > > remaining = length; > > i = 0; -- With Best Regards, Andy Shevchenko
