On 26/10/2020 23:08, Laurent Pinchart wrote:
> Hi Nikhil,
>
> Thank you for the patch.
>
> On Tue, Oct 27, 2020 at 01:39:22AM +0530, Nikhil Devshatwar wrote:
>> Move the vpdma firmware to the toplevel directory so
>> that the existing drivers can use it with the same path.
>>
>> Fixes: 5b30b383ce ("linux-firmware: Add new VPDMA firmware 1b8.bin")
>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@xxxxxx>
>> ---
>> WHENCE | 2 +-
>> ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin | Bin
>
> I think Tomi meant moving the file to ti/ instead of ti-connectivity/. I
> will let him comment on this.
I don't really have a strong opinion here, as I don't know if there are some rules or guidelines
about file/dir naming in linux-firmware.
But my argument is:
The fw should either be at the root dir, where the linux driver is already looking for it, OR, if we
do move it somewhere, move it to a "right" place. Afaics "ti-connectivity" is totally wrong place,
as vpdma has nothing to do with connectivity.
The root dir is a bit bad as "vpdma-1b8.bin" doesn't have TI or such in its name, so even if name
conflict with some other fw feels quite unlikely, the name is still rather vague. And moving is a
bit bad as then the current driver won't find the fw...
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
