On Fri, Oct 16, 2020 at 11:16:06PM +0530, Deepak R Varma wrote:
Hello All,
Request for review / ack of this patch.
Thank you.
Deepak.
> Use of variable vc_num is unnecessary here as it is used only once.
> Instead, the value can directly be used in place of the variable.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
> ---
> Changes since v4:
> - None.
> Changes since v3:
> - None.
> Changes since v2:
> - Implement feedback from Vaishali to simplify patch log message.
> Changes since v1:
> - None.
>
> drivers/staging/media/imx/imx-media-csi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 9320e3974d86..db77fef07654 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
> priv->upstream_ep = upstream_ep;
> is_csi2 = !is_parallel_bus(&upstream_ep);
> if (is_csi2) {
> - int vc_num = 0;
> /*
> * NOTE! It seems the virtual channels from the mipi csi-2
> * receiver are used only for routing by the video mux's,
> @@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
> * enters the CSI's however, they are treated internally
> * in the IPU as virtual channel 0.
> */
> - ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> + ipu_csi_set_mipi_datatype(priv->csi, 0,
> &priv->format_mbus[CSI_SINK_PAD]);
> }
>
> --
> 2.25.1
>
