On 10:52-20201020, Tomi Valkeinen wrote: > On 20/10/2020 10:38, Nikhil Devshatwar wrote: > > On 14:38-20201019, Tomi Valkeinen wrote: > >> On 12/10/2020 15:52, Nikhil Devshatwar wrote: > >>> vpdma firmware is now available in the linux-firmware repo. > >>> > >>> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin > >>> > >>> Update the firmware path requested by the VPDMA driver so that > >>> it gets looked up correctly in the filesystem. > >>> > >>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@xxxxxx> > >>> --- > >>> drivers/media/platform/ti-vpe/vpdma.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c > >>> index 2e5148ae7a0f..5a378449a4ff 100644 > >>> --- a/drivers/media/platform/ti-vpe/vpdma.c > >>> +++ b/drivers/media/platform/ti-vpe/vpdma.c > >>> @@ -23,7 +23,7 @@ > >>> #include "vpdma.h" > >>> #include "vpdma_priv.h" > >>> > >>> -#define VPDMA_FIRMWARE "vpdma-1b8.bin" > >>> +#define VPDMA_FIRMWARE "ti-connectivity/vpdma-1b8.bin" > >> > >> I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for > >> directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion. > > > > The firmware is already merged at ti-connectivity/ > > I didn't create a new folder because I felt the exising ti-connectivity > > is good enough. > > ti-connectivity is for TI wlan, no? I didn't know that. I assumed all ti firmwares regarding connectivity go here :) I am not sure if the linux-firmware accept moving firmware path. I can try posting the patch and see what's the feedback. > I think the fw should either be in the root dir, as that's where > the driver has been loading it from for a long time, or if we're going to change the path in the > driver, put it into a proper directory. > > Tomi > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
