Hi Rob Bot, On Tue, Oct 20, 2020 at 10:30:44AM -0500, Rob Herring wrote: > On Tue, 20 Oct 2020 10:19:21 +0100, Rui Miguel Silva wrote: > > Convert imx7 mipi csi2 bindings documentation to yaml schema, remove > > the textual document and update MAINTAINERS entry. > > > > Signed-off-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx> > > --- > > .../bindings/media/imx7-mipi-csi2.txt | 90 --------- > > .../bindings/media/nxp,imx7-mipi-csi2.yaml | 172 ++++++++++++++++++ > > MAINTAINERS | 2 +- > > 3 files changed, 173 insertions(+), 91 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt > > create mode 100644 Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > ./Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml:91:21: [warning] wrong indentation: expected 22 but found 20 (indentation) > ./Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml:93:21: [warning] wrong indentation: expected 22 but found 20 (indentation) Strange not to complain on line 94 also. > > > See https://patchwork.ozlabs.org/patch/1384742 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade I have done this and I am at version: 2020.8.2.dev4+g341f3e35180a and still do not get any warning on this file. Nevertheless I found the indentation issue and will: > Please check and re-submit. ------ Cheers, Rui