Re: [PATCH 1/4] media: staging: rkisp1: fix coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dafna,

On 10/19/20 5:59 PM, Dafna Hirschfeld wrote:
> Fix checkpatch issues:
> Blank lines aren't necessary before a close brace '}'
> Alignment should match open parenthesis

Just a nit, usually, it's one patch per checkpatch error.

With the split:

Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>

Thanks
Helen

> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
> ---
>  drivers/staging/media/rkisp1/rkisp1-dev.c     | 4 ++--
>  drivers/staging/media/rkisp1/rkisp1-isp.c     | 1 -
>  drivers/staging/media/rkisp1/rkisp1-resizer.c | 4 ++--
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c
> index 91584695804b..4f6ae1a01253 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-dev.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-dev.c
> @@ -254,8 +254,8 @@ static int rkisp1_subdev_notifier(struct rkisp1_device *rkisp1)
>  		struct rkisp1_sensor_async *rk_asd = NULL;
>  		struct fwnode_handle *ep;
>  
> -		ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(rkisp1->dev),
> -			0, next_id, FWNODE_GRAPH_ENDPOINT_NEXT);
> +		ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(rkisp1->dev), 0, next_id,
> +						     FWNODE_GRAPH_ENDPOINT_NEXT);
>  		if (!ep)
>  			break;
>  
> diff --git a/drivers/staging/media/rkisp1/rkisp1-isp.c b/drivers/staging/media/rkisp1/rkisp1-isp.c
> index a9715b0b7264..fb23461d865c 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-isp.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-isp.c
> @@ -1157,5 +1157,4 @@ void rkisp1_isp_isr(struct rkisp1_device *rkisp1)
>  		 */
>  		rkisp1_params_isr(rkisp1);
>  	}
> -
>  }
> diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> index 1687d82e6c68..a9d537c11ecb 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> @@ -610,8 +610,8 @@ static void rkisp1_rsz_set_sink_fmt(struct rkisp1_resizer *rsz,
>  				  RKISP1_ISP_MIN_WIDTH,
>  				  RKISP1_ISP_MAX_WIDTH);
>  	sink_fmt->height = clamp_t(u32, format->height,
> -				  RKISP1_ISP_MIN_HEIGHT,
> -				  RKISP1_ISP_MAX_HEIGHT);
> +				   RKISP1_ISP_MIN_HEIGHT,
> +				   RKISP1_ISP_MAX_HEIGHT);
>  
>  	*format = *sink_fmt;
>  
> 



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux