Hi Deepak,
This is fine with me as long as the comment block just above the #if 0
code is left intact, which it is.
Acked-by: Steve Longerbeam <slongerbeam@xxxxxxxxx>
On 10/16/20 10:40 AM, Deepak R Varma wrote:
The virtual channel is always treated as 0 once the stream enters
CSI's. Commented code in the "#if 0" can be safely removed as it will
not serve any purpose in future. Issue reported by checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
---
Changes since v4:
- Rephrase patch description to make it exact and accurate as
suggested by Julia.
- Add linux-media to the recipient list. Suggested by Hans.
Changes since v3:
- Rephrase Patch description
- Implement feedback from Vaishali & Helen to mention checkpatch in
the patch description.
Changes since v2:
- None
Changes since v1:
- Implement feedback from Julia to be exact with the patch description
drivers/staging/media/imx/imx-media-csi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 21ebf7769696..9320e3974d86 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1131,13 +1131,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
* enters the CSI's however, they are treated internally
* in the IPU as virtual channel 0.
*/
-#if 0
- mutex_unlock(&priv->lock);
- vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
- if (vc_num < 0)
- return vc_num;
- mutex_lock(&priv->lock);
-#endif
ipu_csi_set_mipi_datatype(priv->csi, vc_num,
&priv->format_mbus[CSI_SINK_PAD]);
}
