Hi Sakari,
Thank you for the patch.
On Mon, Oct 12, 2020 at 09:04:14PM +0300, Sakari Ailus wrote:
> If starting a video buffer queue fails, the buffers are returned to
> videobuf2. Remove the reference to the buffer from driver's queue as well.
>
> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v4.16 and up
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index d9baa8bfe54f..51c4dd6a8f9a 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -791,6 +791,7 @@ static void cio2_vb2_return_all_buffers(struct cio2_queue *q,
> atomic_dec(&q->bufs_queued);
> vb2_buffer_done(&q->bufs[i]->vbb.vb2_buf,
> state);
> + q->bufs[i] = NULL;
This looks good, and with Andy's comment addressed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
However, should we replace this with a linked list ?
> }
> }
> }
--
Regards,
Laurent Pinchart
