Hi Andy, On Fri, Oct 09, 2020 at 07:23:57PM +0300, Andy Shevchenko wrote: > On Fri, Oct 9, 2020 at 6:11 PM Sakari Ailus <sakari.ailus@xxxxxx> wrote: > > > > On Fri, Oct 09, 2020 at 06:07:51PM +0300, Sakari Ailus wrote: > > > Hello all, > > > > > > This set addresses most notable subdev format related issues, namely the > > > sub-device sink format being unaccessible. The result of accessing it > > > varied from oopses to crashes. > > > > > > since v1: > > > > > > - Validate try format, too > > > > > > - Set field in subdev format to V4L2_FIELD_NONE > > > > > > - Add a comment explaining the lock > > > > > > - Make values that should be unsigned, unsigned > > > > This is obviously v2. v1 is here: > > v2 is good enough, but few nit-picks here and there. In any case > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Thanks! -- Sakari Ailus