On Fri, Oct 9, 2020 at 12:44 AM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > Pad format can be accessed from user space. Serialise access to it. ... > /* Initialize miscellaneous variables */ > mutex_init(&q->lock); > + mutex_init(&q->subdev_lock); ... > mutex_destroy(&q->lock); > + mutex_destroy(&q->subdev_lock); A nit: perhaps reversed order? > mutex_destroy(&q->lock); > + mutex_destroy(&q->subdev_lock); Ditto. -- With Best Regards, Andy Shevchenko
