On Fri, Oct 9, 2020 at 4:22 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Mon, Aug 17, 2020 at 07:07:31PM +0300, Andy Shevchenko wrote: > > pcim_iomap_table() won't fail if previous pcim_iomap_regions() hasn't. > > Since we check pcim_iomap_regions() for failure the check close to > > pcim_iomap_table() is bogus and not needed. > > + cio2->base = pcim_iomap_table(pci_dev)[CIO2_PCI_BAR]; > > pcim_iomap_table() can return NULL if devres_alloc() runs out of memory. True. And this is checked by pcim_iomap_regions(). So, dup check is not necessary. -- With Best Regards, Andy Shevchenko
