On Fri, Oct 9, 2020 at 4:10 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Mon, Aug 17, 2020 at 07:07:25PM +0300, Andy Shevchenko wrote: > > This constant is used in several places in the code, define it > > for better maintenance. > > #define CIO2_MAX_BUFFERS (PAGE_SIZE / 16 / CIO2_MAX_LOPS) > > +#define CIO2_LOP_ENTRIES (PAGE_SIZE / sizeof(u32)) > > Shouldn't this be CIO2_PAGE_SIZE instead of PAGE_SIZE ? I don't think it makes sense to define this. Then you need to define all others as well and they will be the same as for the CPU/MMU. As I explained in another patch it's quite unlikely that these two will be different. -- With Best Regards, Andy Shevchenko
