Hi Andy,
Thank you for the patch.
On Mon, Aug 17, 2020 at 07:07:32PM +0300, Andy Shevchenko wrote:
> There are assignments inside the functions which are useless.
> Drop them for good.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> v2: new patch
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index f5c27c1aa9a2..f3ec2d62cace 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1979,8 +1979,8 @@ static int __maybe_unused cio2_suspend(struct device *dev)
> static int __maybe_unused cio2_resume(struct device *dev)
> {
> struct cio2_device *cio2 = dev_get_drvdata(dev);
> - int r = 0;
> struct cio2_queue *q = cio2->cur_queue;
> + int r;
>
> dev_dbg(dev, "cio2 resume\n");
> if (!cio2->streaming)
> @@ -2007,7 +2007,7 @@ static const struct dev_pm_ops cio2_pm_ops = {
>
> static const struct pci_device_id cio2_pci_id_table[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, CIO2_PCI_ID) },
> - { 0 }
> + { }
This change is good but doesn't really match the commit message. You may
want to update it. With this addressed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> };
>
> MODULE_DEVICE_TABLE(pci, cio2_pci_id_table);
--
Regards,
Laurent Pinchart
