Hi Sakari,
Thank you for the patch.
On Mon, Oct 05, 2020 at 11:01:15AM +0300, Sakari Ailus wrote:
> Earlier it was expected that there would be more variable size endpoint
> properties and that most if not all drivers would need them. For that
> reason it was expected also that v4l2_fwnode_endpoint_parse would no
> longer be needed.
>
> What actually happened that not all drivers require "link-frequencies",
> the only variable size media endpoint property without a small upper
> limit. Therefore drivers that do not need that information are fine using
> v4l2_fwnode_endpoint_parse. So don't tell drivers to use
> v4l2_fwnode_endpoint_alloc_parse in all cases.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> include/media/v4l2-fwnode.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h
> index 20b30d770944..be30e066c621 100644
> --- a/include/media/v4l2-fwnode.h
> +++ b/include/media/v4l2-fwnode.h
> @@ -245,9 +245,9 @@ struct v4l2_fwnode_connector {
> *
> * The function does not change the V4L2 fwnode endpoint state if it fails.
> *
> - * NOTE: This function does not parse properties the size of which is variable
> - * without a low fixed limit. Please use v4l2_fwnode_endpoint_alloc_parse() in
> - * new drivers instead.
> + * NOTE: This function does not parse "link-frequencies" property as its size is
> + * not known in advance. Please use v4l2_fwnode_endpoint_alloc_parse() if you
> + * need properties of variable size.
> *
> * Return: %0 on success or a negative error code on failure:
> * %-ENOMEM on memory allocation failure
--
Regards,
Laurent Pinchart
