Hi Sakari,
Thank you for the patch.
On Wed, Sep 30, 2020 at 05:48:09PM +0300, Sakari Ailus wrote:
> Don't zero parts of the vep argument to v4l2_fwnode_endpoint_parse()
> anymore as this can no longer be done while still supporting defaults on
> multiple bus types.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/v4l2-core/v4l2-fwnode.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
> index dfc53d11053f..44dd04b05e29 100644
> --- a/drivers/media/v4l2-core/v4l2-fwnode.c
> +++ b/drivers/media/v4l2-core/v4l2-fwnode.c
> @@ -416,20 +416,8 @@ static int __v4l2_fwnode_endpoint_parse(struct fwnode_handle *fwnode,
> enum v4l2_mbus_type mbus_type;
> int rval;
>
> - if (vep->bus_type == V4L2_MBUS_UNKNOWN) {
> - /* Zero fields from bus union to until the end */
> - memset(&vep->bus, 0,
> - sizeof(*vep) - offsetof(typeof(*vep), bus));
> - }
> -
> pr_debug("===== begin parsing endpoint %pfw\n", fwnode);
>
> - /*
> - * Zero the fwnode graph endpoint memory in case we don't end up parsing
> - * the endpoint.
> - */
> - memset(&vep->base, 0, sizeof(vep->base));
> -
> fwnode_property_read_u32(fwnode, "bus-type", &bus_type);
> pr_debug("fwnode video bus type %s (%u), mbus type %s (%u)\n",
> v4l2_fwnode_bus_type_to_string(bus_type), bus_type,
--
Regards,
Laurent Pinchart
