Hi Sakari,
Thank you for the patch.
On Wed, Sep 30, 2020 at 05:48:07PM +0300, Sakari Ailus wrote:
> The v4l2_fwnode_parse_endpoint() function can make use of defaults in
> multiple bus types. To use this feature, all callers must zero the rest of
> the fields of this struct, too. All other drivers appear to do that
> already apart from this one.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
> index 1fe7f97c6d52..ae8b7ebf3830 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -589,14 +589,13 @@ static int adv748x_parse_csi2_lanes(struct adv748x_state *state,
> unsigned int port,
> struct device_node *ep)
> {
> - struct v4l2_fwnode_endpoint vep;
> + struct v4l2_fwnode_endpoint vep = { .bus_type = V4L2_MBUS_CSI2_DPHY };
> unsigned int num_lanes;
> int ret;
>
> if (port != ADV748X_PORT_TXA && port != ADV748X_PORT_TXB)
> return 0;
>
> - vep.bus_type = V4L2_MBUS_CSI2_DPHY;
> ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &vep);
> if (ret)
> return ret;
--
Regards,
Laurent Pinchart
