RE: [PATCH 1/2] v4l2-mem2mem: Code cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

thanks for the patch, one comment below:

>Vaibhav Hiremath (hvaibhav@xxxxxx) wrote:
>
>Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
>---
> drivers/media/video/v4l2-mem2mem.c |   40 ++++++++++++++---------------------
> 1 files changed, 16 insertions(+), 24 deletions(-)

[...]

>@@ -319,10 +317,9 @@ static void v4l2_m2m_try_schedule(struct v4l2_m2m_ctx *m2m_ctx)
> 		return;
> 	}
>
>-	if (!(m2m_ctx->job_flags & TRANS_QUEUED)) {
>-		list_add_tail(&m2m_ctx->queue, &m2m_dev->jobqueue);
>-		m2m_ctx->job_flags |= TRANS_QUEUED;
>-	}
>+	list_add_tail(&m2m_ctx->queue, &m2m_dev->jobqueue);
>+	m2m_ctx->job_flags |= TRANS_QUEUED;
>+
> 	spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags_job);
>
> 	v4l2_m2m_try_run(m2m_dev);

Nice catch! This wasn't the case before, but as v3 is now holding the job_spinlock
for the whole time, the check can be safely removed.

[...]


Acked-by: Pawel Osciak <p.osciak@xxxxxxxxxxx>


Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center





--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux