On Thursday 01 April 2010 11:06:51 Hans Verkuil wrote:
> Here is my review...
>
> > +/**
> > + * v4l2_m2m_release() - cleans up and frees a m2m_dev structure
> > + *
> > + * Usually called from driver's remove() function.
> > + */
> > +void v4l2_m2m_release(struct v4l2_m2m_dev *m2m_dev)
> > +{
> > + kfree(m2m_dev);
> > +}
> > +EXPORT_SYMBOL_GPL(v4l2_m2m_release);
>
> Wouldn't it make sense to embed this struct in a filehandle structure?
That should be the top-level device structure, not the filehandle struct
of course.
Regards,
Hans
> Then there is no need to allocate anything, you just need an init function.
>
> I like embedding structures: it's quite clean.
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
