Em Sun, 27 Sep 2020 11:54:10 +0200 Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> escreveu: > Am 27.09.20 um 11:43 schrieb Mauro Carvalho Chehab: > > Em Tue, 22 Sep 2020 13:34:02 +0200 > > Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> escreveu: > > > >> The function 'rkisp1_stream_start' calls 'rkisp1_set_next_buf' > >> which access the buffers, so the call should be protected by > >> taking the cap->buf.lock. > >> After this patch, all locks are reviewed and commented so remove > >> the TODO item "review and comment every lock" > >> > >> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> > >> --- > >> drivers/staging/media/rkisp1/TODO | 1 - > >> drivers/staging/media/rkisp1/rkisp1-capture.c | 2 ++ > >> 2 files changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/staging/media/rkisp1/TODO b/drivers/staging/media/rkisp1/TODO > >> index f0c90d1c86a8..9662e9b51c7f 100644 > >> --- a/drivers/staging/media/rkisp1/TODO > >> +++ b/drivers/staging/media/rkisp1/TODO > >> @@ -1,6 +1,5 @@ > >> * Fix pad format size for statistics and parameters entities. > >> * Fix checkpatch errors. > >> -* Review and comment every lock > >> * Handle quantization > >> * streaming paths (mainpath and selfpath) check if the other path is streaming > >> in several places of the code, review this, specially that it doesn't seem it > > > > > > FYI, > > > > There was a trivial context conflict here. Basically, the upstream > > version has this: > > > > > > * Add uapi docs. Remember to add documentation of how quantization is handled. > > > > I solved the conflict, but as some patches for rkisp1 got merged > > on a different pull request, and there were some uapi docs at the > > other PR, maybe this would need to be revisited. > > I added the "Configuring Quantization" documentation in Documentation/admin-guide/media/rkisp1.rst > so the TODO item > "* Add uapi docs. Remember to add documentation of how quantization is handled." > can be removed. Ok. Please send a followup patch with a "fixes: " tag mentioned the commit that added it. Thanks, Mauro
