On Mon, Sep 21, 2020 at 01:59:45PM +0300, Dan Carpenter wrote: > On Mon, Sep 21, 2020 at 10:20:12AM +0000, Corentin Labbe wrote: > > This patch adds fallthrough keyword where appropriate. > > > > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> > > --- > > drivers/staging/media/zoran/zoran_device.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c > > index 9558bafdde7d..7634d94f9359 100644 > > --- a/drivers/staging/media/zoran/zoran_device.c > > +++ b/drivers/staging/media/zoran/zoran_device.c > > @@ -268,7 +268,9 @@ static void zr36057_adjust_vfe(struct zoran *zr, enum zoran_codec_mode mode) > > btwrite(reg, ZR36057_VFEHCR); > > break; > > case BUZ_MODE_MOTION_COMPRESS: > > + fallthrough; > > case BUZ_MODE_IDLE: > > + fallthrough; > > default: > > Hopefully, we don't need fallthrough labels for empty switch statements > like this? > I have removed this patch and nothing warn about fallthrough missing. But this is strange, if I have added them, it is because something (checkpatch ?) complained. Anyway, nothing complains now, it is cleaner without them. Thanks
