Hi Kieran,
On Tue, Sep 22, 2020 at 5:52 PM Kieran Bingham
<kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
> Convert the bitfield definitions to use unsigned integers.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -31,85 +31,85 @@
> #include <media/v4l2-subdev.h>
>
> /* Register 0x00 */
> -#define MAX9286_MSTLINKSEL_AUTO (7 << 5)
> +#define MAX9286_MSTLINKSEL_AUTO (7U << 5)
While using this format for multi-bit fields makes sense...
> #define MAX9286_MSTLINKSEL(n) ((n) << 5)
> #define MAX9286_EN_VS_GEN BIT(4)
> -#define MAX9286_LINKEN(n) (1 << (n))
> +#define MAX9286_LINKEN(n) (1U << (n))
... I think single-bit fields (more below) make better use of the BIT() macro.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
