On Wednesday 24 March 2010 06:43:22, Sakari Ailus wrote:
> Hi Arnout,
>
> Thanks for the patch.
>
> Arnout Vandecappelle wrote:
[snip]
> > - dma_sync_sg_for_cpu(q->dev, dma->sglist, dma->nr_pages, dma->direction);
> > + dma_sync_sg_for_cpu(q->dev, dma->sglist, dma->sglen, dma->direction);
>
> I think the same problem still exists --- dma->sglen is not initialised
> anywhere, is it?
Yes it is.
In videobuf_dma_map (where dma->sglist is set), there are two conditions:
if (dma->bus_addr) {
dma->sglist = kmalloc(sizeof(struct scatterlist), GFP_KERNEL);
if (NULL != dma->sglist) {
dma->sglen = 1;
...
}
}
...
if (!dma->bus_addr) {
dma->sglen = dma_map_sg(q->dev, dma->sglist,
dma->nr_pages, dma->direction);
...
}
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
