On Thu, Sep 17, 2020 at 10:47:50AM +0100, Dan Scally wrote: > Hi Greg - thanks for the comments, appreciate it (sorry there's so many, > I'm new to both C and kernel work) It's pretty impressive work if you're new to C... > > > >> + return; > > No error value? > The prototype for sync_state callbacks is to return void, so my > understanding is it can't return an error value. I guess a better thing > to do might be call another function performing cleanup and unloading > the driver before the return or something along those lines though. Yeah. I suspect you should be using a different callback instead of ->sync_state() but I don't know what... :/ regards, dan carpenter
