On Tue, Sep 15, 2020 at 11:06 AM Joakim Zhang <qiangqing.zhang@xxxxxxx> wrote: > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: 2020年9月15日 15:18 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx> > Cc: sean@xxxxxxxx; mchehab@xxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system > On Tuesday, September 15, 2020, Joakim Zhang <qiangqing.zhang@xxxxxxx> wrote: > + ret = pm_runtime_get(dev); > + if (ret < 0) > > > > Here is reference counter leak. > > > > Thanks Andy for your kindly review. > > pm_runtime_get increase the usage_count even it fails, so need call pm_runtime_put_noidle here to balance the usage_count. Am I right? Yes. > + return IRQ_NONE; -- With Best Regards, Andy Shevchenko
