Hi Xiaolin! I found a small memory leak in this flash driver: On Sunday 28 March 2010 09:47:21 Zhang, Xiaolin wrote: > +static int flash_remove(struct i2c_client *client) > +{ > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > + > + v4l2_device_unregister_subdev(sd); Missing kfree(sd). > + > + return 0; > +} -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html