On Wed, Sep 09, 2020 at 07:29:21PM +0800, Wei Yongjun wrote:
> The suspend/resume functions have no callers depending on
> configuration, so they must be marked __maybe_unused to
> avoid these harmless warnings:
>
> drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning:
> 'mmpcam_resume' defined but not used [-Wunused-function]
> 347 | static int mmpcam_resume(struct device *dev)
> | ^~~~~~~~~~~~~
> drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning:
> 'mmpcam_suspend' defined but not used [-Wunused-function]
> 338 | static int mmpcam_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~
>
> Fixes: 55cd34524aa3 ("media: marvell-ccic: add support for runtime PM")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Acked-by: Lubomir Rintel <lkundrak@xxxxx>
Thank you!
Lubo
> ---
> drivers/media/platform/marvell-ccic/mmp-driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
> index c4b28a00a3a2..cd902b180669 100644
> --- a/drivers/media/platform/marvell-ccic/mmp-driver.c
> +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
> @@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)
> return 0;
> }
>
> -static int mmpcam_suspend(struct device *dev)
> +static int __maybe_unused mmpcam_suspend(struct device *dev)
> {
> struct mmp_camera *cam = dev_get_drvdata(dev);
>
> @@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)
> return 0;
> }
>
> -static int mmpcam_resume(struct device *dev)
> +static int __maybe_unused mmpcam_resume(struct device *dev)
> {
> struct mmp_camera *cam = dev_get_drvdata(dev);
>
>
